Create fallback font manager to solve performance drops #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
approved these changes
Apr 29, 2021
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
bbrto21
added a commit
to bbrto21/engine
that referenced
this pull request
Jun 11, 2021
…ter-tizen#78)" This reverts commit 6e859d7.
bbrto21
added a commit
to bbrto21/engine
that referenced
this pull request
Jun 22, 2021
…ter-tizen#78)" This reverts commit c761164.
Merged
bwikbs
pushed a commit
that referenced
this pull request
Jun 23, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes performance drop issue mentioned in #69 (comment). I should have tested the change before it was merged, sorry about that. Now the engine searches fonts in two subdirecotries:
/usr/share/fontand/usr/share/fallback_fonts.The following table compares the start time of the flutter sample counter app.
/usr/share/usr/share/fontand/usr/share/fallback_fontsI had to make some changes to the third-party code to solve the performance issue. I admit its not ideal, so I will look for a better solution when I can.