Support screen rotations for tizen4.0 and tizen6.0 #28

xiaowei-guan · 2021-01-25T03:38:44Z

Screen rotations sequence:
1.Register ecore rotate event callback.
2.Set rotate for ecore window when receive rotate event.
3.Resize ecore window.
4.Resize egl window.
5.Reize flutter UI.
6.Send rotate done before swap buffer.

swift-kim · 2021-01-25T04:56:27Z

shell/platform/tizen/channels/text_input_channel.cc

@@ -102,7 +102,7 @@ void TextInputChannel::InputPanelStateChangedCallback(
    case ECORE_IMF_INPUT_PANEL_STATE_SHOW: {
      FT_LOGD("[PANEL_STATE_SHOW]\n");
      if (self->engine_->device_profile ==
-          "mobile") {  // FIXME : Needs improvement on other devices.
+          "mobileD") {  // FIXME : Needs improvement on other devices.


Is this change intentional?

Yes, we meet some issue when resize window. I am checking this issue.

Could you briefly describe this problem?

we verify egl resize function, only work fine on orientation 0.

Oh...I think I had a similar problem. Thank you for quick response.

Does "mobileD" have any meaning or is it just a placeholder?

"mobileD" just a placeholder,
I add char 'D', just to not run resizing code.

shell/platform/tizen/flutter_tizen.cc

shell/platform/tizen/tizen_embedder_engine.cc

shell/platform/tizen/tizen_renderer.h

Screen rotations sequence: 1.Register ecore rotate event callback. 2.Set rotate for ecore window when receive rotate event. 3.Resize ecore window. 4.Resize egl window. 5.Reize flutter UI. 6.Send rotate done before swap buffer.

1.Remove GetWindowData func. 2.Remove struct WindowData.

bbrto21

LGTM

bbrto21 · 2021-01-27T01:23:21Z

shell/platform/tizen/channels/text_input_channel.cc

@@ -102,7 +102,7 @@ void TextInputChannel::InputPanelStateChangedCallback(
    case ECORE_IMF_INPUT_PANEL_STATE_SHOW: {
      FT_LOGD("[PANEL_STATE_SHOW]\n");
      if (self->engine_->device_profile ==
-          "mobile") {  // FIXME : Needs improvement on other devices.
+          "mobileD") {  // FIXME : Needs improvement on other devices.


Could you briefly describe this problem?

shell/platform/tizen/tizen_renderer_ecore_wl2.h

bbrto21 · 2021-01-27T11:03:04Z

Is there more to discuss?

swift-kim

I tested on a phone (4.0) and a watch (5.5) and had no issue,.

bbrto21 · 2021-01-28T01:19:40Z

#21

* Fix memory corruption issue (#2) * Exit application method is replaced by 'ui_app_exit' (#3) * Fix launch failure in sleep mode (#4) * Fix scorll issue (#6) * Changed EGL settings to support more Tizen devices (#5) * Add touch events of platform view channel for tizen (#8) * Resize egl window when software keyboard is shown (#7) * Fix texture being not released issue (#9) * Remove tizen_tools dependency and update BUILD.gn (#11) * Refactor tizen surface (#10) * Fix a crash in stop phase of Tizen engine (#12) * Fix a crash during app shutdown (#13) * Fix a crash when TizenVsyncWaiter is destroyed. (#15) * Implement key events for tizen webview (#14) * Change method name starting with lower case (#16) * Remove not used code (#18) * Introduce assertion macros (#17) * Minor update to Misc (#19) * Add azure-pipelines.yml (#20) * Clean-up channel view resource upon exiting app (#22) * Call a method to set imf_context in platform view channel (#24) * Support Tizen 4.0 (#23) * Fix a focused platform view bug (#27) * Support screen rotations for Tizen 4.0 and Tizen 6.0 (#28) * Separate the embedder from the engine (#29) * Add profile build to the CI script (#30) * Share egl context to egl resource context (#31) * Implement message queue to handle vblank request (#32) * Fix a platform view bug (#33) * Convert timestamp to correct unit (#35) * Send locales to flutter including default locale (#38) * Enable FontConfig to improve font fallbacks (#40) Co-authored-by: Xiaowei Guan <xiaowei.guan@samsung.com> Co-authored-by: MuHong Byun <mh.byun@samsung.com> Co-authored-by: Boram Bae <boram21.bae@samsung.com> Co-authored-by: Seungsoo Lee <seungsoo47.lee@samsung.com> Co-authored-by: Hakkyu Kim <43136596+HakkyuKim@users.noreply.github.com>

* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See flutter-tizen#28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>

* Improve inputting Korean * Improve log to be useful for development * Improve the readability of filter event * Set more status to edit text properly * Delete preedit text more appropriately * Add DeviceProfile * Removed the resizing code that was blocked for a while Please re-implement it, when the problem is fully identified and solved. See #28 for more details When using ecore-imf, disappointingly, The behavior of several factors related to text input in each device profile is different(such as key-event, calling callbacks for imf). So I've fine-tuned it, but this may not be the best. Maybe it's better to separate it by profile in the future. Signed-off-by: Boram Bae <boram21.bae@samsung.com>