Fix a platform view bug (#33)

* If creating a platform view instance fails, the engine has to send an error to flutter through method channel
flutter-tizen · Feb 3, 2021 · 7a6dd58 · 7a6dd58
1 parent 677661c
commit 7a6dd58
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/shell/platform/tizen/channels/platform_view_channel.cc b/shell/platform/tizen/channels/platform_view_channel.cc
@@ -147,16 +147,19 @@ void PlatformViewChannel::HandleMethodCall(
 
       auto viewInstance =
           it->second->Create(viewId, width, height, byteMessage);
-      view_instances_.insert(
-          std::pair<int, PlatformView*>(viewId, viewInstance));
-
-      if (engine_ && engine_->text_input_channel) {
-        Ecore_IMF_Context* context =
-            engine_->text_input_channel->GetImfContext();
-        viewInstance->SetSoftwareKeyboardContext(context);
+      if (viewInstance) {
+        view_instances_.insert(
+            std::pair<int, PlatformView*>(viewId, viewInstance));
+
+        if (engine_ && engine_->text_input_channel) {
+          Ecore_IMF_Context* context =
+              engine_->text_input_channel->GetImfContext();
+          viewInstance->SetSoftwareKeyboardContext(context);
+        }
+        result->Success(flutter::EncodableValue(viewInstance->GetTextureId()));
+      } else {
+        result->Error("Can't create a webview instance!!");
       }
-
-      result->Success(flutter::EncodableValue(viewInstance->GetTextureId()));
     } else {
       FT_LOGE("can't find view type = %s", viewType.c_str());
       result->Error("Can't find view type");