fix #900 PaymentMethodDataCardFromMethod on iOS #901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonasbark @remonh87 Could you review this PR? |
|
@asaarnak thank you for your PR and raising the issue. This is a class we normally sync from the stripe react native sdk so we do not modify this. I will create a ticket on the react native sdk to ask them if they can fix it. Just to double check did the issue still occur in version 5.0.0 of our library? |
|
@remonh87 Thanks. Jep tested also on 5.0.0. |
|
Thanks for the contribution I created: stripe/stripe-react-native#1124 so Stripe can fix it in their sdk. Will keep an eye on it but will close the PR here, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.