feat(fluent-bit): Support tpl in extraContainers #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredTan95
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
JaredTan95
force-pushed
the
extraContainers_supprt_tpl
branch
from
6ebc719
to
b0e97a6
Compare
stevehipwell
requested changes
Apr 29, 2024
There was a problem hiding this comment.
@JaredTan95 could you rebase this PR and update the chart annotations for this change?
JaredTan95
force-pushed
the
extraContainers_supprt_tpl
branch
4 times, most recently
from
6d38b53
to
4a92681
Compare
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
extraContainers_supprt_tpl
branch
from
4a92681
to
eb423c0
Compare
stevehipwell
requested changes
Apr 30, 2024
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
|
@JaredTan95 you need to bump the chart version or the checks will fail. |
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Done, My chart version is overwritten due to the merging of other PRs before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #163, support tpl in extraContainers.