Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade fluent-operator from v2.3.0 to 2.4.0 #419

Merged
merged 13 commits into from
Sep 6, 2023
Merged

upgrade fluent-operator from v2.3.0 to 2.4.0 #419

merged 13 commits into from
Sep 6, 2023

Conversation

jeffcotts
Copy link
Contributor

No description provided.

@jeffcotts
upgrade fluent-operator from v2.3.0 to 2.4.0
3ab06da 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
update values file
15dd142 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
rm ds_store
2161b43 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
lock operator version
bb7a9e2 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@patrick-stephens
Copy link
Contributor

@benjaminhuo

@benjaminhuo
Copy link
Member

@jeffcotts Thanks for this. Looks like there are some lint errors bb7a9e2

@jeffcotts
fix linting issues
fa03ce9 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
fix more linting issues
d238aa4 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
Copy link
Contributor Author

jeffcotts commented Sep 4, 2023 •
edited
Loading

@jeffcotts Thanks for this. Looks like there are some lint errors bb7a9e2

should be good now! @benjaminhuo

@jeffcotts
upgrade fluent-operator from v2.3.0 to 2.4.0
f60ef7a 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
update values file
be8a60f 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
rm ds_store
5020378 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
lock operator version
fa573d2 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
fix linting issues
aefe5c2 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
fix more linting issues
8321804 
Signed-off-by: Jeff W <jeffcott@protonmail.com>
@jeffcotts
Merge branch 'main' of github.com:jeffcotts/helm-charts
0888440
benjaminhuo
benjaminhuo previously approved these changes Sep 4, 2023
View reviewed changes
@jeffcotts jeffcotts dismissed benjaminhuo’s stale review September 4, 2023 01:12

The merge-base changed after approval.

@benjaminhuo
Copy link
Member

/lgtm
/approve

@benjaminhuo benjaminhuo removed the request for review from wenchajun September 4, 2023 01:13
benjaminhuo
benjaminhuo previously approved these changes Sep 4, 2023
View reviewed changes
@benjaminhuo
Copy link
Member

@patrick-stephens I cannot merge this because of At least 1 approving review is required by reviewers with write access

@jeffcotts jeffcotts dismissed benjaminhuo’s stale review September 4, 2023 01:46

The merge-base changed after approval.

@patrick-stephens
Copy link
Contributor

@patrick-stephens I cannot merge this because of At least 1 approving review is required by reviewers with write access

Sure, @wenchajun is the other codeowner who can approve it to merge.

@benjaminhuo
Copy link
Member

@patrick-stephens I cannot merge this because of At least 1 approving review is required by reviewers with write access

Sure, @wenchajun is the other codeowner who can approve it to merge.

@patrick-stephens I've approved this, but it seems that I'm not on the approval list, Is it possible to add me to the list?

wenchajun
wenchajun previously approved these changes Sep 5, 2023
View reviewed changes
@jeffcotts jeffcotts dismissed wenchajun’s stale review September 5, 2023 01:48

The merge-base changed after approval.

@wenchajun
Copy link
Member

Looks good, but it looks like you've mixed in other people's commits here.

wenchajun
wenchajun previously approved these changes Sep 5, 2023
View reviewed changes
@jeffcotts jeffcotts dismissed wenchajun’s stale review September 5, 2023 07:41

The merge-base changed after approval.

@jeffcotts jeffcotts closed this Sep 5, 2023
@jeffcotts jeffcotts reopened this Sep 5, 2023
@jeffcotts
Copy link
Contributor Author

@benjaminhuo @wenchajun alright i think closing/reopening got rid of the rebased changes 🙏

@benjaminhuo benjaminhuo merged commit c394cb9 into fluent:main Sep 6, 2023
3 checks passed
Matiasmct pushed a commit to giffgaff/fluent-helm that referenced this pull request Oct 24, 2023
@jeffcotts @Matiasmct
upgrade fluent-operator from v2.3.0 to 2.4.0 (fluent#419)
409c476 
* upgrade fluent-operator from v2.3.0 to 2.4.0

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* update values file

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* rm ds_store

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* lock operator version

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* fix linting issues

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* fix more linting issues

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* upgrade fluent-operator from v2.3.0 to 2.4.0

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* update values file

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* rm ds_store

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* lock operator version

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* fix linting issues

Signed-off-by: Jeff W <jeffcott@protonmail.com>

* fix more linting issues

Signed-off-by: Jeff W <jeffcott@protonmail.com>

---------

Signed-off-by: Jeff W <jeffcott@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuo benjaminhuo benjaminhuo approved these changes

@wenchajun wenchajun wenchajun approved these changes

@wanjunlei wanjunlei Awaiting requested review from wanjunlei wanjunlei is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffcotts @patrick-stephens @benjaminhuo @wenchajun