feat: add support for StatefulSet in fluent-bit chart #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresperezl
requested review from
edsiper,
naseemkullah and
stevehipwell
as code owners
Signed-off-by: Andres Perez <andres.perez@ubisoft.com>
andresperezl
force-pushed
the
feat/fluent-bit-statefulset
branch
from
6f07b98
to
b1b1127
Compare
|
@andresperezl thanks for the PR but I'm not sure there is value in adding additional complexity to the existing Fluent Bit chart when the plan moving forwards is to focus on separate charts for collection and aggregation. The following two charts are effectively development versions of the new Fluent Bit charts and the main blocker for bringing them to this repo is process not engineering. I suspect that the aggregator chart would meet your requirements. |
|
Oh nice, didn't know about those, will close this PR then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial support to deploy fluent-bit chart as a StatefulSet, which is helpful when using the Filesystem storage and using fluent-bit as a set of collectors, which allows when scaling fluent-bit to dynamically create the volumes where the data is stored, and also when it recovers so it can keep reading from the same volume in case of a crash.