feat(fluent-bit): Updated dashboard scope #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-stephens
previously approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Not going to review the massive JSON but assume it is fine - any chance you can highlight the changes with a screenshot or something? Previously I did some CI around that - deploying it, running up Grafana then auto-screenshotting and adding to the PR but it is likely overkill.
I notice we increment the plugin version too.
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
fluent-bit-dashboard
branch
from
f5c0941
to
f9b16a7
Compare
patrick-stephens
approved these changes
Jun 23, 2023
|
@patrick-stephens the dashboard should look pretty much identical. I used Grafana to update the dashboard components and then I scoped the queries to only select metrics from components owned by the chart. I've also just updated the PR to make sure that the Prometheus job has a consistent name. |
|
|
Matiasmct
pushed a commit
to giffgaff/fluent-helm
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Fluent Bit chart Grafana dashboard scope to work when there are multiple pods with similar names. It also updates Grafana dashboard components and schemas.