Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msgpack version #171

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
long_description=open(README).read(),
package_dir={'fluent': 'fluent'},
packages=['fluent'],
install_requires=['msgpack<1.0.0'],
install_requires=['msgpack>=1.0.0'],
author='Kazuki Ohta',
author_email='kazuki.ohta@gmail.com',
url='https://github.com/fluent/fluent-logger-python',
Expand Down
2 changes: 1 addition & 1 deletion tests/mockserver.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def get_received(self):
self._buf.seek(0)
# TODO: have to process string encoding properly. currently we assume
# that all encoding is utf-8.
return list(Unpacker(self._buf, encoding='utf-8'))
return list(Unpacker(self._buf))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the mock server to "make tests pass" does nothing to alleviate concerns in #157


def close(self):

Expand Down