-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter_lua: add support for log metadata handling #9702
base: master
Are you sure you want to change the base?
Conversation
Hi @edsiper ! Not sure if you saw, but a few months ago I created a PR which exposes log metadata to Lua in a backwards compatible way: #9323 . #9323 adds a new processor, so internally it is not compatible with filter API. In any case I thought you might find it useful to look at how the public Lua API looks like there, so it could potentially be implemented in a similar manner. |
they @tarruda thanks for reviewing this :) , and thanks for the hints to review the other PRs, definitely I will borrow some of it |
The current Lua filter only supports the processing of the log body and timestamp per record. Metadata support in logs was added recently and this patch extends the filter with a new function prototype and return values to provide metadata manipulation capabilities. The new option called 'enable_metadata', boolean (default: off) allows to use a new prototype for the Lua script which in a new argument receives the metadata as a Lua table, similar concept as the log body is received. The following is an example of the use of this new functionality: pipeline: inputs: - name: dummy processors: logs: - name: lua enable_metadata: true call: test_v2 code: | function test_v2(tag, timestamp, metadata, body) metadata['meta_test'] = 'ok' body['body_test'] = 'ok' return 2, timestamp, metadata, body end outputs: - name : stdout match: '*' For this type of function, is mandatory to return the metadata table, either a new one or an updated version. Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
Introduces a new option called
enable_metadata
(default: false) to the Lua filter so the Lua scripts provided are able to manipulate the metadata of a log record:output:
update: Jan 09, 2024
We will add this functionality as opt-in for v4, in the meanwhile a new processor is created as described in the updated info of Dec 24, 2024.
update: Dec 24, 2024
I have been thinking in the future of this plugin and while adding metadata support as an extra argument to the Lua callback solves the problem, it seems we need a more flexible solution since we will implement also support for metrics and traces, couple of things I have in mind for API
v2
(without breaking compatibility with v1):v2
can only be enabled if the plugin runs as a processor instead of a common filter.cc: adding @niedbalski for visibility.
This is work in progress.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.