dockerfile: packaging: Fix build check for centos-7 and failures of package creations #9043
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
|
In addition, EPEL repo is not moved to use vault. So, we needn't touch it. |
patrick-stephens
previously approved these changes
Jul 4, 2024
|
You don't typically need |
patrick-stephens
added
ok-package-test
|
@cosmo0920 it looks like we have some failures: https://github.com/fluent/fluent-bit/actions/runs/9791908413/job/27037013628?pr=9043 |
|
Oh, we have to handle packaging side of Dockerfile. |
cosmo0920
changed the title
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-fix-centos-7-dockefile
branch
from
c44eb3b
to
4646233
Compare
cosmo0920
requested review from
fujimotos,
edsiper,
leonardo-albertovich and
koleini
as code owners
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-fix-centos-7-dockefile
branch
3 times, most recently
from
ed7295b
to
1ba0b87
Compare
|
I sent patches luajit-cmake which are modified in this PR on zhaozg/luajit-cmake#9. |
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-fix-centos-7-dockefile
branch
from
1ba0b87
to
dcb38b4
Compare
|
@edsiper shall we disable CentOS 7 ARM builds until the PR is merged upstream? |
|
@cosmo0920 there are some luajit stuff in the commits |
|
well, its ok to rebase... |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to EOL of CentOS7 in the end of last month, we need to use vault repo to obtain CentOS 7 packages.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.