Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_winevtlog: Fix threshold condition to avoid unnecessary warning #8771

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Meetp369
Copy link
Contributor

@Meetp369 Meetp369 commented Apr 28, 2024

This pull request addresses a conditioning error in the in_winevtlog.c file.

Currently, even if the highest allowed value (1843200) is set for the read_limit_per_cycle parameter in the configuration file, an unnecessary warning (read limit per cycle cannot exceed) message is still shown without exceeding the maximum threshold size.

MAXIMUM_THRESHOLD_SIZE =1843200.

issue (#8783)

  • Warning log

[2024/04/23 19:33:02] [ warn] [input:winevtlog:winevtlog.0] read limit per cycle cannot exceed 1.8M. Set up to 1.8M

This fix ensures that when the maximum value is set, the warning message is skipped, making the behavior more consistent and clear.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants