Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key. #8093

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

igorpeshansky
Copy link
Contributor

@igorpeshansky igorpeshansky commented Oct 26, 2023

This fixes the use case of specifying the service_account_email and service_account_secret options explicitly.

Fixes #6969


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
    [OUTPUT]
      Name        stackdriver
      Match       …
      service_account_email …
      service_account_secret …
    
  • [N/A] Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

#8094


Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Igor Peshansky <igorp@google.com>
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:24 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:24 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:24 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky changed the title Only set ctx->client_email and ctx->private_key when previously unset. out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key. Oct 26, 2023
Copy link
Collaborator

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:56 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky merged commit b9d0dfb into fluent:master Oct 26, 2023
43 of 46 checks passed
@igorpeshansky igorpeshansky deleted the fix-credentials-options branch October 26, 2023 18:20
@lecaros lecaros added this to the Fluent Bit v2.2.0 milestone Oct 27, 2023
leonardo-albertovich pushed a commit that referenced this pull request Nov 3, 2023
…ey. (#8093)

Signed-off-by: Igor Peshansky <igorp@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackdriver service_account_email and service_account_secret don't work as expected
4 participants