-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_loki: drop quotes after drop_single_key #4353
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mike Frost <Mike.Frost@man.com>
Valid JSON by definition has quotes. Could you use |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
What is necessary to accept this PR? The PR would help to prevent the needless quotes escape (\"). |
In my opinion, a new option should be introduced instead of breaking the existing behavior that conforms to |
Something like a |
It could also be a special value for the |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Removes quotes from log lines when
line_format=json
anddrop_single_key=true
Resolves concerns raised in #3005
Testing
Debug log output from testing the change
Before:
"Nov 19 15:48:36 hostname telegraf: 2021-11-19T15:48:36Z D! [outputs.prometheus_client] Wrote batch of 82 metrics in 648.331µs"
After:
Nov 19 16:05:36 hostname telegraf: 2021-11-19T16:05:36Z D! [outputs.prometheus_client] Wrote batch of 82 metrics in 809.535µs
Attached Valgrind output that shows no leaks or memory corruption was found
Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.