Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#460 Fix handling short pipes in aqua cli #489

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Apr 13, 2022

fixes #460

@DieMyst DieMyst requested a review from alari April 13, 2022 08:30
@DieMyst DieMyst merged commit 42d534a into main Apr 13, 2022
@DieMyst DieMyst deleted the #460-fix-handling-pipes branch April 13, 2022 08:38
@folex
Copy link
Member

folex commented Apr 13, 2022

I'm not sure this behaviour is correct.

If suddenly you get EPIPE, there's no reason you should stop the work you've been doing. It just means that you can't write output anymore, but no reason to stop the work.

I think effects of e.g. aqua run could be meaningful even without output being written.

@folex
Copy link
Member

folex commented Apr 13, 2022

See this answer for a good explanation of different options https://superuser.com/a/554896

And maybe this could be a good solution nodejs/node#947 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aqua cli can't handle writing to short pipes
3 participants