fix: mutating extant resources not forcing new

Relates to fly-apps#154, fly-apps#19.
floydspace · Apr 8, 2023 · 93a6b7f · 93a6b7f
1 parent 5b5133a
commit 93a6b7f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/docs/resources/machine.md b/docs/resources/machine.md
@@ -87,7 +87,7 @@ resource "fly_machine" "exampleMachine" {
 Required:
 
 - `path` (String) Path for volume to be mounted on vm
-- `volume` (String) Name or ID of volume
+- `volume` (String) ID of volume
 
 Optional:
 

diff --git a/internal/provider/app_resource.go b/internal/provider/app_resource.go
@@ -44,12 +44,18 @@ func (ar flyAppResourceType) GetSchema(context.Context) (tfsdk.Schema, diag.Diag
 				MarkdownDescription: "Name of application",
 				Required:            true,
 				Type:                types.StringType,
+				PlanModifiers: tfsdk.AttributePlanModifiers{
+					resource.RequiresReplace(),
+				},
 			},
 			"org": {
 				Computed:            true,
 				Optional:            true,
 				MarkdownDescription: "Optional org slug to operate upon",
 				Type:                types.StringType,
+				PlanModifiers: tfsdk.AttributePlanModifiers{
+					resource.RequiresReplace(),
+				},
 			},
 			"orgid": {
 				Computed:            true,

diff --git a/internal/provider/machine_resource.go b/internal/provider/machine_resource.go
@@ -176,8 +176,11 @@ func (mr flyMachineResourceType) GetSchema(context.Context) (tfsdk.Schema, diag.
 					},
 					"volume": {
 						Required:            true,
-						MarkdownDescription: "Name or ID of volume",
+						MarkdownDescription: "ID of volume",
 						Type:                types.StringType,
+						PlanModifiers: tfsdk.AttributePlanModifiers{
+							resource.RequiresReplace(),
+						},
 					},
 				}),
 			},

diff --git a/internal/provider/volume_resource.go b/internal/provider/volume_resource.go
@@ -53,6 +53,9 @@ func (t flyVolumeResourceType) GetSchema(context.Context) (tfsdk.Schema, diag.Di
 				MarkdownDescription: "Size of volume in gb",
 				Required:            true,
 				Type:                types.Int64Type,
+				PlanModifiers: tfsdk.AttributePlanModifiers{
+					resource.RequiresReplace(),
+				},
 			},
 			"name": {
 				MarkdownDescription: "name",