fix: preserve mtime when zipping with the node zipper #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means it's possible for code to retrieve the correct mtime, for example to return in a `Last-Modified` header. Since we have a test which verifies a checksum of a zip file created by this function, we can be sure the results are deterministic. To support this, update the test inputs to have specified mtimes.
iainlane
force-pushed
the
iainlane/zip-use-mtime-from-filesystem
branch
from
8446c7a to
9c5cbf2
Compare
iainlane
added a commit
to iainlane/coldoutsi.de
that referenced
this pull request
May 27, 2024
`serverless-esbuild`, which we use to build the project, doesn't preserve file modification times. We make use of these times to generate the `last-modified` headers for static files, which we bundle in the Lambda `.zip`s. I [submitted a PR upstream][pr] to fix this. Switch to using a fork containing this fix. The `index` handler was implementing very similar logic to the `static` handler, but slightly differently. We move the `index` handler to the `static` module and make it use the same `fileData` as the `static` handler. This allows us to remove the `index` handler entirely. Add tests for both handlers. This uses a test file stored in the repo. But note that `git` doesn't preserve file modification times, so we have to work these out dynamically in the tests. Fix a nit too: handlers don't have to be async. They can simply return their result directly, no need to wrap it in a `Promise.resolve`. [pr]: floydspace/serverless-esbuild#539
iainlane
added a commit
to iainlane/coldoutsi.de
that referenced
this pull request
May 27, 2024
`serverless-esbuild`, which we use to build the project, doesn't preserve file modification times. We make use of these times to generate the `last-modified` headers for static files, which we bundle in the Lambda `.zip`s. I [submitted a PR upstream][pr] to fix this. Switch to using a fork containing this fix. The `index` handler was implementing very similar logic to the `static` handler, but slightly differently. We move the `index` handler to the `static` module and make it use the same `fileData` as the `static` handler. This allows us to remove the `index` handler entirely. Add tests for both handlers. This uses a test file stored in the repo. But note that `git` doesn't preserve file modification times, so we have to work these out dynamically in the tests. Fix a nit too: handlers don't have to be async. They can simply return their result directly, no need to wrap it in a `Promise.resolve`. [pr]: floydspace/serverless-esbuild#539
floydspace
approved these changes
Sep 24, 2024
|
🎉 This PR is included in version 1.54.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
floydspace
pushed a commit
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means it's possible for code to retrieve the correct mtime, for example to return in a
Last-Modifiedheader. That's what I want to use this for: I'm bundling static assets in my Lambda and I want to be able to have clients cache them properly and send meIf-Modified-Since.Since we have a test which verifies a checksum of a zip file created by this function, we can be sure the results are deterministic. To support this, update the test inputs to have specified mtimes.
Here's a test run on my fork. You can see that I had to drop node 14 from CI, so if a run is approved it'll fail. This seems to be a pre-existing failure on master which you can observe in other PRs.