Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate task features #250

Merged
merged 78 commits into from
Feb 16, 2023
Merged

Integrate task features #250

merged 78 commits into from
Feb 16, 2023

Conversation

floydnant
Copy link
Owner

@floydnant floydnant commented Jan 9, 2023 •
edited
Loading

Resolves #108
Resolves #279
Resolves #203

Changes/Additions

  • Display tasks in tasklist-view and task-view as tree (task-tree.component)
  • Add i/o to task.component → connect to store via task-tree.component
  • Add EntityType.TASK
    • Add icon
    • Add entity view TaskViewComponent
    • Connect tasks to generic entity store
  • Add generic inline-editor
  • Abstract progress bar into its own component
  • Add transition to progress bar + tooltip that shows percentages of tasks
  • Delete tasks and related entities recursively
  • Refactor update queue in editable-entity-heading and disable debounced updates for now

Styling

  • Refactor icon mechanism
  • Change TaskPriority.OPTIONAL icon
  • Adjust spacing across the app (add more padding)

Store

  • Add task service and store
  • Put each entity actions & reducer into their own file
  • Abstract loading states into service and display everywhere

Drop down menu

  • Display icons
  • Add active item state (highlighted)
  • Add menu item wrapper util → better menuItemOperator API

Future Changes

TODO

  • Fix task tree loading state getting stuck, when an empty array is fetched
  • Replace editing mechanics in editable-entity-heading with inline-editor
  • Display task status icons properly in page-entity-icon
  • Display priority icons on menu
  • Fix Loading icon coming with its own color
  • Improve status feature
    • Should indicate a loading state of some form
    • Replace underscores with spaces
  • Implement priority feature
  • Delete tasks recursively
    • Backend e2e tests
  • Write component tests
    • inline-editor
    • task-view
    • tasklist-view (??)
    • task
    • task-tree
  • Write unit tests
    • Menu item helpers
  • git bisect the problem that causes e2e tests to fail
  • Write e2e tests
    • Tasks [...]

@floydnant floydnant added the web Issue related to the front end label Jan 9, 2023
@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited
Loading

✅ Deploy Preview for rockket ready!

Name Link
🔨 Latest commit 1e100d6
🔍 Latest deploy log https://app.netlify.com/sites/rockket/deploys/63ee7ec3a2dc490008ac62eb
😎 Deploy Preview https://deploy-preview-250--rockket.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@railway-app
Copy link

railway-app bot commented Jan 9, 2023 •
edited
Loading

This PR is being deployed to Railway 🚅

Server: ◻️ REMOVED

@floydnant floydnant closed this Jan 10, 2023
@floydnant floydnant reopened this Jan 10, 2023
@floydnant floydnant closed this Jan 10, 2023
@floydnant floydnant reopened this Jan 10, 2023
@floydnant floydnant force-pushed the dev/integrate-task branch 2 times, most recently from a28cec2 to ad6d3ce Compare January 13, 2023 18:13
floydnant and others added 11 commits January 22, 2023 23:38
@floydnant
Add workflows to create & drop databases for PRs (#251)
85b1ed3 
* Add db workflows
* Add railway env config file
@dependabot @floydnant
Bump eslint from 8.30.0 to 8.31.0 in /server (#249)
9bd6c69 
Bumps [eslint](https://github.com/eslint/eslint) from 8.30.0 to 8.31.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.30.0...v8.31.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @floydnant
Bump prisma from 4.7.1 to 4.8.1 in /server (#248)
cea1521 
Bumps [prisma](https://github.com/prisma/prisma/tree/HEAD/packages/cli) from 4.7.1 to 4.8.1.
- [Release notes](https://github.com/prisma/prisma/releases)
- [Commits](https://github.com/prisma/prisma/commits/4.8.1/packages/cli)

---
updated-dependencies:
- dependency-name: prisma
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @floydnant
Bump postcss from 8.4.20 to 8.4.21 in /client-v2 (#247)
464117a 
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.20 to 8.4.21.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.20...8.4.21)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @floydnant
Bump joi from 17.6.0 to 17.7.0 in /server (#243)
b8854f4 
Bumps [joi](https://github.com/hapijs/joi) from 17.6.0 to 17.7.0.
- [Release notes](https://github.com/hapijs/joi/releases)
- [Commits](hapijs/joi@v17.6.0...v17.7.0)

---
updated-dependencies:
- dependency-name: joi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @floydnant
Bump eslint-plugin-tailwindcss from 3.7.1 to 3.8.0 in /client-v2 (#242)
46e9869 
Bumps [eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss) from 3.7.1 to 3.8.0.
- [Release notes](https://github.com/francoismassart/eslint-plugin-tailwindcss/releases)
- [Commits](francoismassart/eslint-plugin-tailwindcss@v3.7.1...v3.8.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-tailwindcss
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @floydnant
Bump cypress from 12.2.0 to 12.3.0 in /client-v2 (#241)
2c435b7 
Bumps [cypress](https://github.com/cypress-io/cypress) from 12.2.0 to 12.3.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md)
- [Commits](cypress-io/cypress@v12.2.0...v12.3.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@floydnant
Merge main into dev/integrate-task
31d46b7
@floydnant
Add task service and store
01824e8
@floydnant
Load and display tasks in tasklist-view, add i/o to task.component & …
b2c28e6 
…connect to store, update progress bar
@floydnant
Add EntityType.TASK, refactor everything related(add task view, hook …
02a76d6 
…up entitiesService for tasks, add task store stuff)
@floydnant floydnant added the backend Related to the back end label Jan 23, 2023
@floydnant floydnant marked this pull request as ready for review February 13, 2023 21:01
@floydnant floydnant merged commit 5d0dcee into main Feb 16, 2023
@floydnant floydnant deleted the dev/integrate-task branch February 16, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Related to the back end web Issue related to the front end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor icons Refactor editable-entity-name.component Integrate available task features
1 participant
@floydnant