-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Complete entity refactor [rebased] (#263)
* Change entity field `name` to `title` and refactor everything related * Put `task` and `list` folders into new `entities` module * Copy models folder from client into `fullstack-shared` folder * Hook up syncing between projects * Move entity previews endpoint from `list.controller` to `entities.controller` * Use `EntityPreview` instead of `TasklistPreview` * Update entities.actions to use `EntityCrudDto` (i.e. the entityType), update related files * Remove hardcoded `EntityType` values * Put entity store details into a map * Add local "ci" script that runs all checks for a given project
- Loading branch information
Showing
83 changed files
with
760 additions
and
412 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
client-v2/src/app/components/atoms/icons/page-entity-icon/page-entity-icon.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
client-v2/src/app/components/atoms/icons/priority-icon/priority-icon.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 0 additions & 28 deletions
28
.../src/app/components/molecules/editable-entity-heading/editable-entity-name.component.html
This file was deleted.
Oops, something went wrong.
File renamed without changes.
26 changes: 26 additions & 0 deletions
26
...src/app/components/molecules/editable-entity-heading/editable-entity-title.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<div class="inline-flex items-center" *ngIf="entity$ | async as entity"> | ||
<span> | ||
<page-entity-icon | ||
class="mr-2.5 inline-block -translate-y-0.5 text-2xl" | ||
[icon]="(isLoading$ | async) ? PageEntityState.LOADING : entity.entityType" | ||
> | ||
</page-entity-icon> | ||
</span> | ||
|
||
<span | ||
class="title | inline-block min-w-[2rem] cursor-text outline-none" | ||
[innerText]="entityTitle$ | async" | ||
[class.show-placeholder]="!(entityTitleDomState$ | async)" | ||
[attr.data-placeholder]="ENTITY_TITLE_DEFAULTS[entity.entityType]" | ||
#editableEntityTitle | ||
contenteditable | ||
focusable | ||
#entityTitleFocusable="focusable" | ||
[spellcheck]="entityTitleFocusable.isFocused" | ||
(textChanges)="entityTitleChanges$.next($event)" | ||
[mutationOptions]="{ plainOnly: true, observe: entityTitleFocusable.isFocused }" | ||
(keydown)="keydownEvents$.next($event)" | ||
(blur)="blurEvents$.next($event)" | ||
data-test-name="editable-entity-name" | ||
></span> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.