fix: dont emit undefined as binding config

floydnant · Nov 25, 2023 · 03189b9 · 03189b9
1 parent 8fbb779
commit 03189b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/client-v2/src/app/components/molecules/entity-description/entity-description.component.html b/client-v2/src/app/components/molecules/entity-description/entity-description.component.html
@@ -12,7 +12,7 @@
 
 <app-tt-editor
     #descriptionTtEditor
-    [bind]="bindConfig$ | push : 'native'"
+    [bind]="bindConfig$ | push"
     (isActive)="isActive$.next($event)"
     (updateOnBlur)="updateInput$.next($event)"
     (blur)="blurInput$.next($event)"

diff --git a/client-v2/src/app/rich-text-editor/tip-tap-editor/tip-tap-editor.component.ts b/client-v2/src/app/rich-text-editor/tip-tap-editor/tip-tap-editor.component.ts
@@ -102,8 +102,8 @@ export class TipTapEditorComponent<TContext = unknown> implements OnDestroy {
     )
 
     private bindConfig$ = new Subject<{ input$: Observable<string>; context: TContext }>()
-    @Input() set bind(bound: { input$: Observable<string>; context: TContext }) {
-        this.bindConfig$.next(bound)
+    @Input() set bind(bindConfig: { input$: Observable<string>; context: TContext } | undefined) {
+        if (bindConfig) this.bindConfig$.next(bindConfig)
     }
     private bound$ = this.bindConfig$.pipe(
         untilDestroyed(this),