FEATURE: add option to exclude child document nodes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kdambekalns, I just realised, this pull request is open since July. |
|
Thanks for the reminder… it is maintained on an as-needed basis, since we don't use it ourselves. I had overlooked this one… |
|
I might add some more pull requests soon, as I'm currently using it in a larger project. Just have to figure out, what the translation agency needs to work optimally. |
|
I'll look at this when #17 is merged, to have the Neos 7 changes "out of the way". |
|
I dropped the Neos 7 changes as they were handled by someone else in the meantime. Also updated the feature code to work with the refactored ExportService. |
|
Oh, how time flies… sorry! |
This makes the code to collect content for a document a little less generic, but more concise.
kdambekalns
approved these changes
Sep 13, 2022
|
Released with v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a use case in a project where we needed to export only a specific page itself without any child pages. That's why we added the option to do exactly this (
--exclude-child-documents).On the way, some deprecated classes were replaced and the project was declared compatible with the current flow version.