Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Service Integration Tests #66

Conversation

minhnguyen-ai
Copy link
Contributor

Description

Added integration tests for the Workflow Service to ensure its functionality and reliability.

Changes Made

  • Created a new DTO: AuditEntityDTO.
  • Updated the default value for auditor to Optional.empty instead of -1.
    • Previously, when createdBy was set to -1, it caused an error while saving a workflow.
    • Since there is no valid user ID of -1, workflows could not be saved.
    • The new default value prevents this issue and ensures proper handling.

@minhnguyen-ai minhnguyen-ai changed the title Initial integration tests Workflow Service Integration Tests Feb 7, 2025
@haiphucnguyen
Copy link
Contributor

Your PR looks very good, thank you for contributing to FlowInquiry. But it fails to publish, it is the issue of the repo action. Let me fix it then I will merge your PR

@haiphucnguyen haiphucnguyen merged commit d344e53 into flowinquiry:main Feb 7, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants