Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v0.93.x for cookie-parser #3164

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Conversation

edahlseng
Copy link
Contributor

  • Links to documentation:
  • Link to GitHub or NPM:
  • Type of contribution: fix

Other notes:
It looks like in flow v0.93.x, http$IncomingMessage is now a parameterized generic type. This pull request copies the existing cookie-parser definitions, and updates every instance of http$IncomingMessage with http$IncomingMessage<> (which is also what express does, since the types are copied from express).

(Side note: I notice that there's a large number of types that have been copied from express. Is there any way to reference those types without copying them? That may have helped to prevent this issue!)

@pascalduez
Copy link
Member

See
facebook/flow#7215
#3157

(Side note: I notice that there's a large number of types that have been copied from express. Is there any way to reference those types without copying them? That may have helped to prevent this issue!)

Not at the moment, see #2842

Copy link
Member

@pascalduez pascalduez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants