Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize context valid identifier check #340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Richtermeister
Copy link

This might seem like a micro-optimization, but we are using this library in a tight loop with a large input map, and the regex usage is adding up. This PR contains a commit with the benchmark used.

goos: linux
goarch: amd64
pkg: github.com/flosch/pongo2/v6
cpu: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
BenchmarkCheckForValidIdentifiers/regex-8         	 5310591	       231.0 ns/op	       0 B/op	       0 allocs/op
BenchmarkCheckForValidIdentifiers/char_check-8    	127916318	         9.171 ns/op	       0 B/op	       0 allocs/op

Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant