Add asgi-correlation-id #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What is this project?
asgi-correlation-id is a pretty straight forward request ID logging middleware for ASGI apps. Was unable to find a maintained mature package when looking for one, so I created this. Hopefully it can of use to others.
Do you know about other similar projects?
Starlette context does something similar, but requires manual implementation of log filters to get a basic request ID logging setup. I wouldn't compare them, but that's the most similar popular package I know of.
If so, how is this one different?
Single purpose and includes everything you need to get set up without any additional code.
Anyone who agrees with this pull request can add a 👍.