Add New Relic ASGI integration #48
Conversation
Adding in a link under monitoring for New Relic's ASGI API
README.md
Outdated
| @@ -82,7 +82,7 @@ _Packages for building GraphQL APIs via ASGI._ | |||
| _Packages for monitoring ASGI web applications._ | |||
|
|
|||
| <!-- sort_by:name --> | |||
|
|
|||
| - [New Relic ASGI](https://docs.newrelic.com/docs/agents/python-agent/python-agent-api/asgiapplication-python-agent-api) - New Relic's API for ASGI web servers and frameworks. | |||
There was a problem hiding this comment.
Should we try and align the presentation here with the Sentry SDL entry?
We'd need to point in which PyPI package this integration can be sound, and update the phrasing to something like...
New Relic integration for ASGI applications. (Shipped with
<package>.)
(I know this doesn't match the "ASGI frameworks" phrasing in the Sentry entry, but I don't think that phrasing is ideal, since the integration can be used even on apps that don't fit within a given "framework".)
There was a problem hiding this comment.
The New Relic integration includes API calls that can be used with New Relic's python agent. The support was shipped with the following release of NR's python agent package: https://pypi.org/project/newrelic/5.16.2.147/.
There is also direct agent support now for Uvicorn Server: https://pypi.org/project/newrelic/5.20.0.149/ and Starlette support is next.
I am interested in your opinion on capturing this. Do you think the following would be clear enough?
New Relic integration for ASGI applications. (Shipped with newrelic)
There was a problem hiding this comment.
New Relic integration for ASGI applications. (Shipped with newrelic.)
Yup, sounds great! :-)
There was a problem hiding this comment.
Thank you for your feedback! I made those changes.
I updated the wording and formatting for the newrelic integration to match the other monitoring entries as well as included the PyPi package name.
|
@florimondmanca The PR is ready for approval and to be merged. Let me know if there is something else I should do. Thank you! |
|
Thank you @florimondmanca! We are glad to be on the list :-) |
Adding in a link under monitoring for New Relic's ASGI API
Checklist
What is this project?
Do you know about other similar projects?
If so, how is this one different?
Anyone who agrees with this pull request can add a 👍.