Encode \uXXXX
unescapes as ASCII_8BIT
#484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incompatible encoding issue when the source string mixes
\uXXXX
escape sequences with unescaped UTF-8 characters:It looks like
gsub
raises this error when you call it on aforce-encoded ascii-8bit string and replace with a utf-8 one (as is done
in
convert_encoding
andparse_string
):To fix the issue, this adds another
force_encoding
to make thereplacement string encoding match the source one. I believe the behavior
should be the same as
convert_encoding
.