Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect schedule in certain timezone when using hash cron extention #67

Closed
phibid opened this issue Mar 8, 2022 · 7 comments
Closed
Assignees

Comments

@phibid
Copy link

phibid commented Mar 8, 2022

Opening an issue here too after opening it in Gitlab, https://gitlab.com/gitlab-org/gitlab/-/issues/354513, as it seems that Fugit is being used in Gitlab for the cron process.

The use of the cron hash extension don't give the correct schedule in some timezone.
For example, in UTC, 30 18 * * 2#5 will correctly be scheduled the last Tuesday of this month, the 29th.
However, in Paris timezone, it will be scheduled in 2 months, the last Tuesday of May, the 24th.

Not sure if this issue is coming from Fugit or from the implementation done by Gitlab, but if you think that you are not concerned by this bug, just feel free to close this issue.

@jmettraux jmettraux self-assigned this Mar 8, 2022
@jmettraux
Copy link
Member

Hello @phibid, what version of fugit is used by Gitlab?

Thanks in advance.

@jmettraux
Copy link
Member

@jmettraux
Copy link
Member

@phibid thanks for reporting that.

I'm seeing the issue with fugit 1.2.1 and the current 1.5.3 pre.

Although it points at the fifth Tuesday of May for me, 2022-05-31 but not the 2022-05-24 you seem to be seeing.

I will attempt to fix that. Give me a few days.

@phibid
Copy link
Author

phibid commented Mar 8, 2022

Ah yes sorry, typo, last Tuesday of May being the "May 31, 2022 6:30pm GMT+0200", not the 24th

Thanks !

jmettraux added a commit to floraison/et-orbi that referenced this issue Mar 9, 2022
jmettraux added a commit to floraison/et-orbi that referenced this issue Mar 9, 2022
jmettraux added a commit that referenced this issue Mar 9, 2022
jmettraux added a commit that referenced this issue Mar 9, 2022
@jmettraux
Copy link
Member

@phibid Please upgrade your et-orbi gem to 1.2.7 and try again. Tell me if it fixes the issue for you.

@phibid
Copy link
Author

phibid commented Mar 9, 2022

Thanks ! However I am not directly using Fugit, but through Gitlab. Let me add this info in the original Gitlab issue and see the progression on this. Thanks again, will keep you updated.

@jmettraux
Copy link
Member

@phibid OK, I saw your added info on Gitlab, I will complement it there.

Closing the issue here. I am ready to re-open it if necessary.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants