Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sokol_gfx.h gl: fix max number of storage buffer bindings (fixes #1193) #1196

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

floooh
Copy link
Owner

@floooh floooh commented Jan 22, 2025

This reduces the max occupied storage buffer bindslots in the GL backend from 16 to 8 (same as the max number of storage buffer bindings across all shader stages).

Requires a matching sokol-shdc update (floooh/sokol-tools#170), since previously sokol-shdc would assign fragment shader storage buffer bindings starting at slot 16 (now sokol-shdc simply uses the original binding 0..7).

TODO:

  • fix any places in sokol-tools code comments and documentation which may refer to GL bindings from 0..15
  • fix any places in sokol_gfx.h code comments which may refer to GL bindings from 0..15
  • sokol-tools changelog
  • sokol changelog
  • add release-mode out-of-range check for glsl_binding_n

@floooh floooh merged commit 363189b into master Jan 23, 2025
32 checks passed
@floooh floooh deleted the issue1193_fix_gl_sbuf_bindings branch January 23, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant