Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zig master build.zig #87

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix zig master build.zig #87

merged 1 commit into from
Dec 19, 2024

Conversation

AndrewKraevskii
Copy link
Contributor

ziglang/zig#20388 broke build.zig so new hack should be made :(

@floooh
Copy link
Owner

floooh commented Dec 19, 2024

Hmm, looks very hacky indeed :)

I'd link to understand the change in the Zig build system first before merging, maybe I can think of a different way.

@floooh
Copy link
Owner

floooh commented Dec 19, 2024

Ok, I'll merge the PR but will try to come up with a different way to detect when the new code path is needed, maybe checking the major Zig version is enough (e.g. assuming that everybody who's on 14.x is on the bleeding edge anyway).

@floooh floooh merged commit a80df6f into floooh:master Dec 19, 2024
0 of 3 checks passed
@floooh
Copy link
Owner

floooh commented Dec 19, 2024

Hmm there's something else broken since the Emscripten build doesn't link against the sokol C library anymore. Investigating...

@floooh
Copy link
Owner

floooh commented Dec 19, 2024

Hmm ok, looks like lib_main.getCompileDependencies(false); is not a drop-in replacement for lib_main.root_module.iterateDependencies(options.lib_main, false);... investigating...

@floooh
Copy link
Owner

floooh commented Dec 19, 2024

Ok, this seems to work (also much simpler than before):

9d11321

...I'll test with pacman.zig next.

@floooh
Copy link
Owner

floooh commented Dec 19, 2024

PS: thanks for the PR (also looking into your dcimgui PR next).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants