Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare sokol-shdc for storage buffer support. #120

Merged
merged 121 commits into from
May 9, 2024
Merged

Prepare sokol-shdc for storage buffer support. #120

merged 121 commits into from
May 9, 2024

Conversation

floooh
Copy link
Owner

@floooh floooh commented Mar 18, 2024 •
edited
Loading

...which then actually turned into a major refactoring...

Related sokol PR: floooh/sokol#1007

TODO:

  • reflection for depth textures is broken
  • update documentation
  • update changelog
  • fix gl storage buffer bind offset in fragment shader (needs to start at bind slot 8)
  • test via sokol-samples:
    • macOS + Metal
    • macOS + GL
    • iOS + Metal
    • iOS + GL
    • Windows + D3D11
    • Windows + GL
      • reset state cache fails after clear buffer bindings (too many storage buffer bind slots?) => fails at bind index 16
      • ...check if binding fragment storage buffer works (e.g. sokol-shdc uses the right offset, bind slot base must be 0 for vertex and 8 for fragment stage)
    • Linux + GL
    • Android + GL
    • web + WebGL2
    • web + WebGPU
  • fix error lines being off-by-2 (or sometimes off-by-1)
  • only allow readonly storage buffers (for now)
  • fix storage buffer struct alignment (can be 4, 8, 12 or 16) => just use the 'outer' struct size as alignment
  • cannot use struct size as alignment since alignment must be a power of two (error: requested alignment is not a power of 2)
  • refactor generators:
    • C
      • ifdef IMPL
      • remove DECL
    • Zig
    • Nim
    • Rust
    • Odin
    • Bare
    • BareYaml
  • get storage buffer readonly reflection flag
  • fix sdhc crash #104
  • restrict storage buffer interior to a single struct flexible array
  • reflect that single toplevel struct
  • recursively mark all matrixes in storage buffers as col-major this whole col-major patching does in fact nothing and has been removed
  • fix GL codegen error for cgltf-sapp sample: VALIDATE_SHADERDESC_UB_SIZE_MISMATCH: size of uniform block members doesn't match uniform block size
  • bring generators uptodate (storage buffers etc):
    • C
    • Zig
    • Nim
    • Rust
    • Odin
    • Bare
    • BareYaml
  • fix build.zig

floooh added 30 commits March 12, 2024 19:41
@floooh
a bit of reflection related code cleanup
a05193f
@floooh
add a simple ssbo.glsl test shader
9151db1
@floooh
remove glsl100 and glsl330 support, add glsl410 and glsl430
4c99084
@floooh
start splitting shdc.h
9ba3f3c
@floooh
code cleanup wip
eea8845 
- split shdc.h into more focused headers
- move output format sources into subdirectory
- start renaming types attr_t => VertexAttr, bytecode_blob_t
  BytecodeBlob
@floooh
errmsg_t => ErrMsg
08c2f47
@floooh
format_t => Format
daff293
@floooh
image_sample_type_tag_t => ImageSampleTypeTag
ee90720
@floooh
image_sample_type_t => ImageSampleType
347bcd2
@floooh
image_sampler_t => ImageSampler
7f3ad98
@floooh
image_type_t => ImageType
49498bb
@floooh
image_t => Image
e924cf3
@floooh
line_t => Line
c15fac6
@floooh
option_t => Option
ee57271
@floooh
program_t => Program
a96c098
@floooh
sampler_type_tag_t => SamplerTypeTag
ffc3b86
@floooh
sampler_type_t => SamplerType
72d7a43
@floooh
sampler_t => Sampler
894ee0b
@floooh
slang_t => Slang
41751a8
@floooh
snippet_t => Snippet
faafbb8
@floooh
spirv_blob_t => SpirvBlob
9a324ea
@floooh
spirvcross_source_t => SpirvcrossSource
635600f
@floooh
stage_t => ShaderStage, uniform_block_t => UniformBlock
9cd5b2d
@floooh
uniform_t => Uniform, args_t => Args
41d5778
@floooh
bytecode_t => Bytecode
74b2ff3
@floooh
input_t => Input
c735b06
@floooh
reflection_t => Reflection
9a65e82
@floooh
spirv_t => Spirv
0605ed6
@floooh
spirvcross_t => Spirvcross
313d0a1
@floooh
Format::type_t => Format::Enum
075e14d
floooh added 24 commits April 20, 2024 18:11
@floooh
update test shaders
517e6a7
@floooh
add error check which only allows readonly SSBOs
2265bd0
@floooh
fix entry_point name postfix for MSL
507f405
@floooh
add storage buffer support to zig code generator
4403170
@floooh
code generators: fix slang-specific entry point name
ba107b5
@floooh
fix zig code generator storage buffer support
5beeb07
@floooh
zig codegen: explicitly align all struct items expect first one to (1)
7c85af9
@floooh
update Odin code generator and minor code cleanup
423f4da
@floooh
fix odin generator coding style
bb6bb0f
@floooh
nim code generator wip
52ed086
@floooh
nim code generator wip2
1b39ed1
@floooh
update and fix nim code generator
0288595
@floooh
zig and odin codegen fixes
2cacd1d
@floooh
update rust codegen (storage buffers), and remove optional stubs from…
7a422f9 
… other generators
@floooh
update yaml generator for storage buffers
f91e87a
@floooh
fix build.zig
76cd68b
@floooh
fix error line index for tags
615ec68
@floooh
fix error and warning line numbers being off
8b56781
@floooh
add back glsl330 and some code cleanup
49b618e
@floooh
remove glsl330 again but keep code cleanup
1cc5cdb
@floooh
update documentation
ef42f66
@floooh
fix gl storage buffer bind slot offset in fragment stage
60e182e
@floooh
improve a comment
69794fb
@floooh
add a special 'reflection slang' which forces zero-based bind slots
83ccabf
@floooh floooh mentioned this pull request May 4, 2024
Merged
@floooh floooh marked this pull request as ready for review May 4, 2024 15:28
@floooh floooh merged commit 2cac6cf into master May 9, 2024
6 checks passed
@floooh floooh deleted the storage-buffers branch May 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@floooh