Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Odin bindings, DLL support #11

Merged
merged 16 commits into from
Apr 13, 2024

Conversation

jakubtomsu
Copy link
Contributor

This PR is closely linked to floooh/sokol#1023, it contains all the info

@floooh
Copy link
Owner

floooh commented Apr 11, 2024

See my comments in the sokol PR. I'll try to take care of the PRs on the weekend.

@floooh
Copy link
Owner

floooh commented Apr 13, 2024

Don't worry about the merge conflict. I'll try to do the merge locally, and hopefully it's enough to rerun the code generation with your changes in both repos.

@floooh floooh merged commit c181703 into floooh:main Apr 13, 2024
3 checks passed
@floooh
Copy link
Owner

floooh commented Apr 13, 2024

And merged. I also did:

  • add a changelog file (similar to the one in sokol-zig)
  • made the .sh files to build the library executable

Interestingly I didn't see any merge conflicts when doing the merge locally (while the Github PR UI said there would be conflicts).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants