support EIP-1559 on all custom chains #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewMcArthur
suggested changes
Nov 15, 2021
I thought that too when I first looked at the API but it actually stands for "greater than or equal to hardfork" |
|
ah, okay. nice :)
On Mon, Nov 15, 2021 at 8:14 AM Matt Holtzman ***@***.***> wrote:
on my phone and haven't left github reviews before, but looks like you
have a typo when you call gteHardfork
I thought that too when I first looked at the API but it actually stands
for "greater than or equal to hardfork"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#621 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHJMWPZJP5LUC3E37XBC53UMEBS3ANCNFSM5G7FQ3LQ>
.
--
------------------------------------------
Drew McArthur
***@***.***
|
floating
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this check was falling back to the known configuration in the ethereumjs/common library, which didn't exist for certain custom chains. This fixes EIP-1559 for any chain that doesn't ship with a common configuration, including but not limited to Arbitrum, Optimism, Avalanche and xDai.