Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update balances when custom token details change #1412

Merged
merged 1 commit into from
Feb 10, 2023
Merged

update balances when custom token details change #1412

merged 1 commit into from
Feb 10, 2023

Conversation

mholtzman
Copy link
Collaborator

No description provided.

@mholtzman mholtzman requested a review from Jamchello February 8, 2023 19:15
@Jamchello
Copy link
Contributor

@mholtzman as part of this ticket do we want to also address the issue re: custom tokens that are deleted initially dissapear for a short period, before appearing back in the balances?

@mholtzman
Copy link
Collaborator Author

@mholtzman as part of this ticket do we want to also address the issue re: custom tokens that are deleted initially dissapear for a short period, before appearing back in the balances?

no, if thats still an issue we can create a ticket for it and address it separately

@Jamchello
Copy link
Contributor

@mholtzman as part of this ticket do we want to also address the issue re: custom tokens that are deleted initially dissapear for a short period, before appearing back in the balances?

no, if thats still an issue we can create a ticket for it and address it separately

Okay, created a ticket for this in triage.

This PR LGTM 👍

@mholtzman mholtzman merged commit 92c2923 into develop Feb 10, 2023
@mholtzman mholtzman deleted the custom-token-update branch February 10, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamchello Jamchello Jamchello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mholtzman @Jamchello