Fix/autofocusing #1408
Merged
Fix/autofocusing #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholtzman
reviewed
Feb 8, 2023
mholtzman
reviewed
Feb 8, 2023
mholtzman
reviewed
Feb 8, 2023
| const useFocusableRef = (focus) => { | ||
| const ref = useRef(null) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
can probably just wrap this whole thing in an if (focus) so we dont need to invoke the hook and can get rid of the other conditional logic
There was a problem hiding this comment.
Wrapping the useEffect in an if caused a React error, moving this if(focus) inside the hook does the trick and looks cleaner howver!
I have also added the delay parameter back as I realised on the initial input we can focus much quicker as there is no animation.
There was a problem hiding this comment.
ahh interesting, didn't know that. looks good!
mholtzman
approved these changes
Feb 9, 2023
| const useFocusableRef = (focus) => { | ||
| const ref = useRef(null) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
ahh interesting, didn't know that. looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.