Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render accounts if signer disconnected when in expanded view #1345

Merged
merged 6 commits into from
Jan 18, 2023

Conversation

goosewobbler
Copy link
Contributor

If you disconnect a signer when in expanded view the current behaviour is to render null - we should render the accounts.

@goosewobbler goosewobbler added bug Something isn't working hardware signers UX labels Jan 14, 2023
@mholtzman
Copy link
Collaborator

I don't think we want to render the accounts in the signer view, this will mess up the navigation. probably it's better to just navigate back to the main accounts panel if a signer is removed

@mholtzman
Copy link
Collaborator

I think this implementation will still cause the "back" button from the account screen to go back to the signer. maybe @floating has a better idea of how the nav works specifically but I think the idea here is when we remove a signer (most likely in the Signers module) we also remove any nav related to that signer from the stack so that the view will naturally go back

@goosewobbler goosewobbler added the WIP PRs that are still in progress and not ready for review or merging label Jan 16, 2023
@goosewobbler
Copy link
Contributor Author

goosewobbler commented Jan 16, 2023

@mholtzman something like navClearReq but for signers?

EDIT: prototyped, looking at tests

@goosewobbler goosewobbler removed the WIP PRs that are still in progress and not ready for review or merging label Jan 17, 2023
app/dash/App.js Outdated Show resolved Hide resolved
@goosewobbler goosewobbler added the WIP PRs that are still in progress and not ready for review or merging label Jan 17, 2023
@goosewobbler goosewobbler removed the WIP PRs that are still in progress and not ready for review or merging label Jan 18, 2023
@goosewobbler goosewobbler merged commit 8db99c4 into develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hardware signers UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants