Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3774] Fix 5V on GPIO #4103

Merged
merged 10 commits into from
Feb 20, 2025
Merged

[FL-3774] Fix 5V on GPIO #4103

merged 10 commits into from
Feb 20, 2025

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Feb 7, 2025 •
edited by skotopes
Loading

What's new

  • 5V on GPIO no longer being disabled when USB cable is unplugged
  • OTG (5V on GPIO) power management moved to the power service

Verification

  • Disable 5V on GPIO in the GPIO app
  • Plug the USB cable into your device
  • Enable 5V on GPIO
  • Unplug the USB cable
  • The 5V power should resume within a second of the cable being unplugged
  • Also check SubGHz with external modules, iButton, Infrared, and Power CLI since those apps were migrated to the new power control scheme as well.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Compiled f7 firmware for commit a206e012:

@skotopes skotopes merged commit 2817666 into dev Feb 20, 2025
11 checks passed
@skotopes skotopes deleted the astra/3774-keep-5v branch February 20, 2025 03:37
murthal

This comment was marked as off-topic.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murthal murthal murthal left review comments

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @murthal