Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mf_classic_dict.nfc with Proxmark3 version #4013

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

onovy
Copy link
Contributor

@onovy onovy commented Nov 22, 2024

What's new

  • all MF keys from Flipper has been synced to PM3
  • as pointed out here PM3 repository is good reference dictionary to use
  • i don't see point in maintaining own copy of dictionary based on older version of PM3, so I'm proposing to completely replace it with newest PM3 version

Verification

compared old and new dictionary with script:

grep -v '^#' OLD | grep -v '^$'  | tr '[:lower:]' '[:upper:]' | sort | uniq > OLD2
grep -v '^#' NEW | grep -v '^$'  | tr '[:lower:]' '[:upper:]' | sort | uniq > NEW2
diff OLD2 NEW2

And no keys are removed, only added.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes merged commit 7d5358b into flipperdevices:dev Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants