Replace all calls to strncpy with strlcpy, use strdup more, expose strlcat #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookiePLMonster
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov,
nminaylov and
Skorpionm
as code owners
CookiePLMonster
force-pushed
the
strlcpy-upgrades
branch
from
aa6d0cb to
d7bce62
Compare
skotopes
requested changes
Sep 6, 2024
|
Un-draft when ready |
CookiePLMonster
force-pushed
the
strlcpy-upgrades
branch
from
f31f563 to
155a196
Compare
…rlcat strlcpy doesn't zero the buffer and ensures null termination, just like snprintf strlcat is already used by mjs and it's a safe alternative to strcat, so it should be OK to expose to apps
CookiePLMonster
force-pushed
the
strlcpy-upgrades
branch
from
155a196 to
c041413
Compare
skotopes
approved these changes
Sep 7, 2024
ofabel
pushed a commit
to ofabel/flipperzero-firmware
that referenced
this pull request
Sep 26, 2024
…rlcat (flipperdevices#3866) strlcpy doesn't zero the buffer and ensures null termination, just like snprintf strlcat is already used by mjs and it's a safe alternative to strcat, so it should be OK to expose to apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
This PR improves the consistency of string copy calls, removing all uses of
strncpyandstrcat, at least from the code that isn't in submodules.strlcpyis preferable overstrncpy, because it doesn't needlessly zero the remaining destination buffer, and it ensures null-termination.Because
strlcatis already used in mjs, I exposed it in the API. Please check if this is fine.To make buffer sizes consistent, I modified the following constants to include the space for the null terminator. Please check if this is fine:
IBUTTON_KEY_NAME_SIZEINFRARED_MAX_BUTTON_NAME_LENGTHINFRARED_MAX_REMOTE_NAME_LENGTHMAX_TEXT_INPUT_LENVerification
Checklist (For Reviewer)