Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .editorconfig #3811

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Fix .editorconfig #3811

merged 1 commit into from
Jul 27, 2024

Conversation

leon0399
Copy link
Contributor

@leon0399 leon0399 commented Jul 27, 2024 •
edited by hedger
Loading

I was copying best practices to my project exploring firmware, and spotted a typo

What's new

  • Fixed editor config for Makefiles

Verification

  • IDEs won't alert on this

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

hedger
hedger requested changes Jul 27, 2024
View reviewed changes
Copy link
Member

@hedger hedger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use Makefiles anymore, so you can remove this block altogether :)

@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Jul 27, 2024
@hedger hedger self-assigned this Jul 27, 2024
@hedger hedger merged commit 173ecc8 into flipperdevices:dev Jul 27, 2024
11 checks passed
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@leon0399 @ofabel
Remove unused entries from .editorconfig (flipperdevices#3811)
f3be6f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger approved these changes

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees

@hedger hedger

Labels
Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leon0399 @hedger