Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordered VS-Code Tasks to follow the [Release] > [Debug] schema #3810

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Reordered VS-Code Tasks to follow the [Release] > [Debug] schema #3810

merged 2 commits into from
Jul 27, 2024

Conversation

janwiesemann
Copy link
Contributor

@janwiesemann janwiesemann commented Jul 27, 2024

What's new

VS-Code talks where being places in a random order. Sometimes the '[Release]' tasks were placed before '[Debug]' tasks and sometimes they've been place in the [Debug]' -> '[Release]' order. This is annoying, if you're using a extension such as Task Runner and you constantly have to search for the correct item.

Verification

Just run a few of the tasks.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added the Build System & Scripts fbt, scripts and toolchain-related label Jul 27, 2024
@hedger
Copy link
Member

hedger commented Jul 27, 2024

When using Control(Command)+Shift+B task list, it will be sorted in the order of recent usage. That list also support quick search by typing parts of build task names. In such case, the actual order of tasks in .json is irrelevant.

However, for ease of maintenance, your PR makes sense.

@hedger hedger self-assigned this Jul 27, 2024
@hedger hedger merged commit 0223c23 into flipperdevices:dev Jul 27, 2024
11 checks passed
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System & Scripts fbt, scripts and toolchain-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants