Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add missing va_end call #3798

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix: Add missing va_end call #3798

merged 2 commits into from
Jul 31, 2024

Conversation

derskythe
Copy link
Contributor

@derskythe derskythe commented Jul 21, 2024 •
edited by skotopes
Loading

By PR #3797

What's new

  • The changes ensure that the va_end function is always called after c_vsnprintf in mjs_array.c

Verification

  • In mjs_array.c by heap

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@derskythe
fix: Ensure proper closure of variadic function in mjs_array
fdd680a 
The changes ensure that the `va_end` function is always called after `c_vsnprintf` in `mjs_array.c`
@hedger hedger added Bug JS JS Runtime, loader and API labels Jul 21, 2024
@skotopes skotopes merged commit 56fef61 into flipperdevices:dev Jul 31, 2024
11 checks passed
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@derskythe @skotopes @ofabel
fix: Ensure proper closure of variadic function in mjs_array (flipp…
445d729 
…erdevices#3798)

The changes ensure that the `va_end` function is always called after `c_vsnprintf` in `mjs_array.c`

Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Bug JS JS Runtime, loader and API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derskythe @skotopes @hedger