Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3832] Use static synchronisation primitives #3679

Merged
merged 27 commits into from
Jun 5, 2024
Merged

[FL-3832] Use static synchronisation primitives #3679

merged 27 commits into from
Jun 5, 2024

Conversation

gsurkov
Copy link
Member

@gsurkov gsurkov commented May 31, 2024 •
edited by skotopes
Loading

What's new

  • Use static FreeRTOS synchronisation primitives in furi wrappers:
    • FuriMutex
    • FuriSemaphore
    • FuriStreamBuffer
    • FuriEventGroup
  • Refactor FuriTimer and remove redundant code
  • Refactor FuriThread to only use *Static functions
  • Service threads are now using their own constructor
  • Turn off dynamic allocation in FreeRTOS config
  • Update unit tests
  • Update relevant documentation

Verification

  1. Install firmware with unit tests enabled: ./fbt FIRMWARE_APP_SET=unit_tests flash_usb_full
  2. Run the unit tests from Flipper command line: unit_tests. Everything should pass.
  3. Run the whole suite of integration tests.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Compiled f7 firmware for commit fb859475:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

PVS-Studio report for commit ce4bc34e:

@gsurkov gsurkov marked this pull request as ready for review June 4, 2024 15:33
@gsurkov gsurkov requested review from skotopes and DrZlo13 as code owners June 4, 2024 15:33
@hedger hedger added Core+Services HAL, furi & core system services Documentation Everything related to docs & code comments labels Jun 4, 2024
hedger
hedger previously approved these changes Jun 4, 2024
View reviewed changes
@skotopes skotopes merged commit 20c4121 into dev Jun 5, 2024
11 checks passed
@skotopes skotopes deleted the gsurkov/3832_static_primitives branch June 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@hedger hedger hedger left review comments

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services Documentation Everything related to docs & code comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsurkov @hedger @skotopes