BadUSB: BLE, media keys, Fn/Globe key commands #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled f7 firmware for commit |
nminaylov
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov and
drunkbatya
as code owners
|
PVS-Studio report for commit |
nminaylov
changed the title
skotopes
approved these changes
Mar 25, 2024
vanguacamolie
added a commit
to vanguacamolie/flipperzero-firmware
that referenced
this pull request
Mar 31, 2024
Commit 6de2934 (BadUSB: BLE, media keys, Fn/Globe key commands (flipperdevices#3403), 2024-03-25) changed the life-cycle of the bad_usb_script object, so that the bad_usb_script is allocated when entering the work scene, and freed when going to the config scene. It also made it so that the keyboard layout always gets reloaded when entering the work scene. The logic of the layout config scene, however, assumes that it still needs to reload the keyboard layout after selecting it. The keyboard layout data is stored within bad_usb_script however, which is NULL when within the layout config scene. The fix is simple. Since we are now reload the keyboard layout anyway when entering the work scene, we can just remove this extra call.
vanguacamolie
added a commit
to vanguacamolie/flipperzero-firmware
that referenced
this pull request
Mar 31, 2024
Commit 6de2934 (BadUSB: BLE, media keys, Fn/Globe key commands (flipperdevices#3403), 2024-03-25) changed the life-cycle of the bad_usb_script object, so that the bad_usb_script is allocated when entering the work scene, and freed when going to the config scene. It also made it so that the keyboard layout always gets reloaded when entering the work scene. The logic of the layout config scene, however, assumes that it still needs to reload the keyboard layout after selecting it. The keyboard layout data is stored within bad_usb_script however, which is NULL when within the layout config scene. The fix is simple. Since we are now reload the keyboard layout anyway when entering the work scene, we can just remove this extra call. Resolves: flipperdevices#3552
3 tasks
skotopes
pushed a commit
that referenced
this pull request
Apr 1, 2024
Commit 6de2934 (BadUSB: BLE, media keys, Fn/Globe key commands (#3403), 2024-03-25) changed the life-cycle of the bad_usb_script object, so that the bad_usb_script is allocated when entering the work scene, and freed when going to the config scene. It also made it so that the keyboard layout always gets reloaded when entering the work scene. The logic of the layout config scene, however, assumes that it still needs to reload the keyboard layout after selecting it. The keyboard layout data is stored within bad_usb_script however, which is NULL when within the layout config scene. The fix is simple. Since we are now reload the keyboard layout anyway when entering the work scene, we can just remove this extra call. Resolves: #3552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
MEDIAcommand for pressing Media/Consumer control keysGLOBEcommand for Fn/Globe key combos ([BadUSB Feature Request] Is there a way use the iPadOS "globe" key? #3089)Verification
Checklist (For Reviewer)