Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SavedStruct: Introduce saved_struct_get_metadata #3392

Merged
merged 4 commits into from
Mar 25, 2024

Toolbox: add saved struct documentation

1dea549
Select commit
Loading
Failed to load commit list.
Merged

SavedStruct: Introduce saved_struct_get_metadata #3392

Toolbox: add saved struct documentation
1dea549
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Mar 25, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
All 3 parameters became optional, as the user might not necessarily care about them all. Incomplete
The functionality of saved_struct_get_payload_size is entirely superseded, so I felt like it's appropriate to replace it instead of adding a new API call. Incomplete
saved_struct_save gets its data parameter const-qualified. This change needs no further explanation, and since I bumped up the API version with the other change anyway, I went for it. I also const-qualified all the functions in other modules that exclusively called saved_struct_save. Incomplete
PR has description of feature/bug or link to Confluence/Jira task Completed
Description contains actions to verify feature/bugfix Completed
I've built this code, uploaded it to the device and verified feature/bugfix Completed