Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITSO Parser (UK) #3325

Merged
merged 6 commits into from
Feb 6, 2024
Merged

ITSO Parser (UK) #3325

merged 6 commits into from
Feb 6, 2024

Conversation

gsp8181
Copy link
Contributor

@gsp8181 gsp8181 commented Dec 28, 2023 •
edited by gornekich
Loading

What's new

  • ITSO parser added to NFC app. ITSO is a standard for UK transport cards (aside from Oyster). Used for rail, bus and subway passes across GB. This parser grabs the card number and expiry date. More information is available on the card but locked behind propriety apps and an extensive database of station stops and operators is needed.

Verification

  • Scan an ITSO card and verify that the number matches the number printed on the card. Expiry date will match if printed on the card.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@gsp8181
Create ITSO parser
893ff57 
Standard for UK transport cards outside of Oyster
@gsp8181
Update application.fam with ITSO parser
67445c9
@gornekich
Copy link
Member

Hello @gsp8181 ! Thanks for PR!
Could you please share example .nfc file to verify your PR? You can send it here or DM me in Discord gornekich

@hedger hedger added the NFC NFC-related label Dec 28, 2023
@skotopes skotopes mentioned this pull request Jan 5, 2024
Closed
gornekich
gornekich requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@gornekich gornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gsp8181
Sorry for late review. I tested you PR, everything works great!
Please, make some changes to make code look better and we will merge PR.

applications/main/nfc/plugins/supported_cards/itso.c Outdated Show resolved Hide resolved
applications/main/nfc/plugins/supported_cards/itso.c Outdated Show resolved Hide resolved
@gornekich
Copy link
Member

gornekich commented Jan 10, 2024 •
edited
Loading

By the way, we already have #3294 which introduces furi_hal_rtc_timestamp_to_datetime() function. Let's wait when that PR is merged and rework this PR with this function

@skotopes skotopes marked this pull request as draft January 16, 2024 06:31
@skotopes
Copy link
Member

Un-draft when ready

@gornekich gornekich marked this pull request as ready for review February 6, 2024 18:33
@hedger hedger added the New Feature Contains an IMPLEMENTATION of a new feature label Feb 6, 2024
@gornekich gornekich requested a review from gsurkov as a code owner February 6, 2024 18:33
@hedger hedger requested a review from gornekich February 6, 2024 18:54
@gornekich gornekich merged commit e180266 into flipperdevices:dev Feb 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gornekich gornekich gornekich approved these changes

@hedger hedger hedger approved these changes

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees

@gornekich gornekich

Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsp8181 @gornekich @skotopes @hedger