Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Pioneer SR IR remotes #3308

Merged
merged 10 commits into from
Mar 22, 2024
Merged

Add support for Pioneer SR IR remotes #3308

merged 10 commits into from
Mar 22, 2024

Conversation

radioegor146
Copy link
Contributor

@radioegor146 radioegor146 commented Dec 22, 2023 •
edited by skotopes
Loading

What's new

  • Added support for the Pioneer SR IR remotes

Verification

  • Read Pioneer SR IR remote command
  • Send command to some piece of Pioneer hardware with SR support

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@radioegor146 radioegor146 changed the title add support for Pioneer SR IR remotes Add support for Pioneer SR IR remotes Dec 22, 2023
@hedger hedger added the Infrared Infrared app label Dec 24, 2023
@skotopes
Copy link
Member

@radioegor146 can you also add unit tests to https://github.com/flipperdevices/flipperzero-firmware/blob/dev/applications/debug/unit_tests/infrared/infrared_test.c ?

@radioegor146
Copy link
Contributor Author

Working on it!

@radioegor146
Copy link
Contributor Author

radioegor146 commented Dec 29, 2023 •
edited
Loading

@skotopes does infrared testset work currenly? Because as I try to run unit_tests infrared Flipper just hangs (even w/o my changes).

@skotopes
Copy link
Member

skotopes commented Dec 29, 2023 •
edited
Loading

@skotopes does infrared testset work currenly? Because as I try to run unit_tests infrared Flipper just hangs (even w/o my changes).

Yes, all PRs are going through unit tests.
Most likely you forgot to upload unit test assets.

@skotopes
Copy link
Member

@gsurkov can you do review?

@gsurkov
Copy link
Member

gsurkov commented Feb 9, 2024

@radioegor146 Is there any progress on unit tests? Do you need help with that?

@radioegor146
Copy link
Contributor Author

Thanks for helping with tests

@gsurkov
Copy link
Member

gsurkov commented Mar 22, 2024

@radioegor146 I've modified the decoder a bit so that it would accept the input from its own encoder (it wasn't the case due to different stop bit handling in either of them)

@skotopes skotopes merged commit 2aa2dcc into flipperdevices:dev Mar 22, 2024
10 checks passed
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Mar 24, 2024
@radioegor146 @gsurkov @xMasterX
Add support for Pioneer SR IR remotes (flipperdevices#3308)
d1d3c43 
* add support for Pioneer SR IR remotes
* fix minor issues
* fix repeat
* Fix protocol enumeration order
* Add unit tests for Pioneer IR protocol
* Clean up raw test data
* Add encoder/decoder tests, modify parser
* Remove dead code
* Use loops where appropriate

Co-authored-by: Georgii Surkov <37121527+gsurkov@users.noreply.github.com>
Co-authored-by: Georgii Surkov <georgii.surkov@outlook.com>
@Cgomez664
Copy link

I need help understanding everithing but I really what I see can somebody take there time and help me I promise I will make I back to you and I just got my flipper and I want to learn how to use it

@skotopes
Copy link
Member

I need help understanding everithing but I really what I see can somebody take there time and help me I promise I will make I back to you and I just got my flipper and I want to learn how to use it

http://docs.flipper.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees

@gsurkov gsurkov

Labels
Infrared Infrared app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@radioegor146 @skotopes @gsurkov @Cgomez664 @hedger