Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: build wheels for macos arm64 in Cirrus CI #42

Merged
merged 3 commits into from
Jan 21, 2023

Conversation

oscarbenjamin
Copy link
Collaborator

This adds Cirrus CI configuration that can build macOS arm64 wheels.

Cirrus CI needs to be enabled on the repo before this will work.

@oscarbenjamin
Copy link
Collaborator Author

@fredrik-johansson can you enable Cirrus CI on this repo?

The link is here:
https://github.com/marketplace/cirrus-ci

Only the "public repositories" (free) level is needed. After it asks for a name and address and some access to your github account to see your repos. It's possible to enable it only on one repo though.

@fredrik-johansson
Copy link
Collaborator

Cirrus CI seems to be installed now.

@oscarbenjamin
Copy link
Collaborator Author

Thanks. Looks like it's working. It should take about 15 minutes to produce the wheels.

@oscarbenjamin
Copy link
Collaborator Author

oscarbenjamin commented Jan 8, 2023

It's working. I've tested one of the wheels locally.

Next what is needed is to patch GMP:
aleaxit/gmpy#352 (comment)

I want to try to reproduce this issue first so that I can confirm the fix:
aleaxit/gmpy#350

@oscarbenjamin
Copy link
Collaborator Author

I want to try to reproduce this issue

Actually I'm really not sure how I would reproduce that because obviously I've compiled python_flint rather than gmpy. The equivalent code for python_flint doesn't have any problem but that doesn't really prove anything. I think it's clear that GMP needs to be patched though (various other environments apply this patch for macos arm64).

@oscarbenjamin
Copy link
Collaborator Author

I've added the patch for OSX arm64 and tested the wheel from Cirrus CI locally and it works.

@oscarbenjamin
Copy link
Collaborator Author

Okay, I think this is good to go.

@oscarbenjamin oscarbenjamin merged commit 63be308 into flintlib:master Jan 21, 2023
@oscarbenjamin oscarbenjamin deleted the pr_macos_arm64 branch January 21, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants