Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PUT, PATCH, DELETE methods for data #620

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

KnifeLemon
Copy link
Contributor

No description provided.

@n0nag0n
Copy link
Collaborator

n0nag0n commented Feb 5, 2025

Hey there, thanks for the contribution! I will try to get to this in the next couple of days (been slammed lately). Did you happen to run composer test-coverage and was the coverage 100%?

@n0nag0n
Copy link
Collaborator

n0nag0n commented Feb 6, 2025

So I went ahead and fixed the unit test errors. I had to correct some of the logic as I think some of what you wanted would have caused problems for certain types of requests. Can you look over the final PR and let me know if I solved the problem in the way you were hoping? I'm assuming that you were shooting for form encoded values and not JSON request correct?

@KnifeLemon
Copy link
Contributor Author

So I went ahead and fixed the unit test errors. I had to correct some of the logic as I think some of what you wanted would have caused problems for certain types of requests. Can you look over the final PR and let me know if I solved the problem in the way you were hoping? I'm assuming that you were shooting for form encoded values and not JSON request correct?

Yes, the way you wrote it is correct. It is correct to handle form encoded values, not json format.

@n0nag0n n0nag0n merged commit 62bf542 into flightphp:master Feb 13, 2025
6 checks passed
@n0nag0n
Copy link
Collaborator

n0nag0n commented Feb 13, 2025

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants