Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit electron export target #753

Merged
merged 3 commits into from
Dec 11, 2021
Merged

Conversation

kasinskas
Copy link
Collaborator

Description

Specify target platform in electron-builder command (https://www.electron.build/cli) to enable building other platforms, because "without target configuration, electron-builder builds Electron app for current platform and current architecture using default target", so on a mac even if i run rnv export -p windows I get mac build in a windows folder

Breaking Changes

  • PRs should not introduce breaking changes to existing functionality
  • if breaking change cannot be avoided it has to be introduced in 2 phases (release cycles of 0.x.0)
    • 0.x.0 Add new functionality + add DEPRECATED warning to existing fuctionality
    • 0.[x+1].0 Remove deprecated functionality

I have tested my changes on:

ReNative project directly:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

New project:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

Existing Project created with previous version of renative:

  • ios simulator
  • ios device
  • android simulator
  • android device
  • web browser
  • web -e next browser
  • tvos simulator
  • tvos device
  • androidtv simulator
  • androidtv device
  • androidwear simulator
  • androidwear device
  • tizen simulator
  • tizen device
  • tizenmobile simulator
  • tizenwatch device
  • webos simulator
  • webos device
  • macos
  • windows
  • chromecast device

@kasinskas kasinskas requested a review from pavjacko December 2, 2021 14:58
@codecov-commenter
Copy link

Codecov Report

Merging #753 (e7525eb) into develop (5260998) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #753   +/-   ##
========================================
  Coverage    19.88%   19.88%           
========================================
  Files           85       85           
  Lines         5883     5883           
  Branches      1332     1332           
========================================
  Hits          1170     1170           
  Misses        3515     3515           
  Partials      1198     1198           
Flag Coverage Δ
rnvunittests 19.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5260998...e7525eb. Read the comment docs.

@kasinskas kasinskas mentioned this pull request Dec 3, 2021
@pavjacko pavjacko merged commit 4e66791 into develop Dec 11, 2021
@pavjacko pavjacko deleted the feat/electron-target branch February 15, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants